Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] fix: Dto 하위 필드에 @Valid 추가 #845

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

donghoony
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • DTO 하위에 @Valid를 붙였습니다.

🔥 어떻게 해결했나요 ?

  • 살펴보니 한 군데밖에 없더라고요.., 이슈에는 있어서 우선 PR로 해결합니다 🚀

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • RequestBody 받는 곳이 생각보다 없습니다. 혹시나 놓친 부분 있나 확인해주세요 🙇🏻

📚 참고 자료, 할 말

Copy link

github-actions bot commented Oct 12, 2024

Test Results

146 tests  ±0   146 ✅ ±0   4s ⏱️ -1s
 55 suites ±0     0 💤 ±0 
 55 files   ±0     0 ❌ ±0 

Results for commit 1b35a30. ± Comparison against base commit b6d03d1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단 굳굳🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewGroupController에서 @Valid@RequestBody 명시 순서가 서로 다른 부분이 있는데 그 부분만 통일 시켜주면 좋을 것 같아요~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했어용~

Copy link
Contributor

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳~ 어푸루브 합니다~ 😋💯

Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단 굳 어프룹~

@donghoony donghoony merged commit 6b3a8d3 into develop Oct 14, 2024
5 checks passed
@donghoony donghoony deleted the be/fix/826/recursive-dto-validation branch October 14, 2024 08:36
skylar1220 pushed a commit that referenced this pull request Oct 15, 2024
* fix: Dto 하위 필드에 `@Valid` 추가

* chore: `@Valid @ResponseBody` 순서 통일
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE] DTO에 재귀적 valid 처리를 한다.
4 participants