refactor: Memory -> Category 도메인명 변경 및 API URI 변경 #595 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
메서드의 파라미터명 변경 - memoryId -> categoryId - newMemory -> newCategory
메서드명 변경 - ...Memory -> ...Category - getMemories -> getCategories
- memoryApiService -> categoryApiService
- MemoryRemoteDataSource -> CategoryRemoteDataSource
- memoryDataSource -> categoryDataSource
- memoryId -> categoryId - newMemory -> newCategory
- MemoryDefaultRepository -> CategoryDefaultRepository
- memories -> categories
- memoryId -> categoryId - memoryTitle -> categoryTitle
- memories -> categories
- memoryId -> categoryId - memoryTitle -> categoryTitle
- MemoriesResponse -> CategoriesResponse
- MemoryCandidateResponse -> CategoryCandidateResponse
- memoryId -> categoryId
- memoryId -> categoryId
- MemoryCreationResponse -> CategoryCreationResponse
- memoryThumbnailUrl -> categoryThumbnailUrl - memoryTitle -> categoryTitle
- memoryThumbnailUrl -> categoryThumbnailUrl - memoryTitle -> categoryTitle
- MemoryRequest -> CategoryRequest
- memoryId -> categoryId - memoryThumbnailUrl -> categoryThumbnailUrl - memoryTitle -> categoryTitle
- memoryId -> categoryId - memoryThumbnailUrl -> categoryThumbnailUrl - memoryTitle -> categoryTitle
- MemoryResponse -> CategoryResponse
- MemoryStaccatoDto -> CategoryStaccatoDto
- memoryId -> categoryId
- memoryId -> categoryId
- memoryId -> categoryId - memoryTitle -> categoryTitle
- memoryId -> categoryId - memoryTitle -> categoryTitle
API URL 변경에 따라, serial name의 moment를 staccato로 변경 - momentId -> staccatoId - momentImageUrls -> staccatoImageUrls
API URL 변경에 따라, serial name의 moment를 staccato로 변경 - momentImageUrls -> staccatoImageUrls
- momentImageUrls -> staccatoImageUrls
- momentImageUrls -> staccatoImageUrls
API URL의 변경에 따라, moment를 staccato로 변경
- moments -> staccatos
- momentId -> staccatoId
동반객체 활용
- STACCATO_ID = "staccatoId"
- STACCATO_PATH_WITH_ID = "$STACCATOS_PATH/{$STACCATO_ID}"
- moment -> staccato
feature/#595 branch에 develop branch의 최신 변경 사항을 반영
- import 알파벳 순서에 따라 재정렬 - 들여쓰기 조정 - line당 글자수 초과한 코드 개행 처리
- 업데이트할 기분을 String이 아닌 도메인 모델 Feeling으로 변경 - StaccatoDefaultRepository에서 toFeelingRequest Mapper 메서드 활용
2 tasks
- MemoryCandidateFixture -> CategoryCandidateFixture
- Memory -> Category - MemoryStaccato -> CategoryStaccato
hxeyexn
approved these changes
Jan 31, 2025
URI에 남아있는 moment를 staccato로 변경 - 버저닝을 위해 comments 경로에 /v2 추가 - momentId -> staccatoId 로 변경
GET, POST 요청에만 v2 적용하도록 변경 - 버저닝 URI인 COMMENTS_URI_V2
다른 ApiService에서 사용하는 변수명과 통일 - URI -> PATH
s6m1n
approved these changes
Feb 6, 2025
- develop branch의 변경 사항을 해당 기능 branch(feature/#595)에 반영
- convertMemoryUriToFile -> convertCategoryUriToFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️ Issue Number
🚩 Summary
AccountInformation과MyProfile을 제거했습니다.convertExcretaToFile)의 이름을convertStaccatoUriToFile로 변경했습니다.🙂 To Reviewer
📋 To Do