feat: 로깅 적용 #581 #639
Open
feat: 로깅 적용 #581 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 바텀 시트 상태가 머무는 시간을 계산하기 위해 previousTime 프로퍼티 생성 - calculateTimeDuration에서 밀리초를 초 단위(소수점 포함)로 계산하여 반환 - 각 바텀시트 상태가 변경될 때 마다 바텀 시트 상태, 머문 시간을 로깅
- ktlint 적용(imports 수정)
프래그먼트 진입 시간을 저장하는 변수와 구분하기 위해, 바텀 시트 상태 시간을 저장하는 변수명 변경 - previousTime -> previousBottomSheetStateTime
- calculateTimeDuration -> calculateBottomSheetTimeDuration
AnalyticsEvent - NAME_FRAGMENT_PAGE 제거 Param - KEY_FRAGMENT_NAME 제거 - PARAM_CATEGORY_LIST 제거 - PARAM_CATEGORY_FRAGMENT 제거 - PARAM_STACCATO_FRAGMENT 제거
Junyoung-WON
approved these changes
Feb 13, 2025
s6m1n
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️ Issue Number
🚩 Summary
🙂 To Reviewer
공동 작업한 PR 이므로 누락된 로깅이 없는지만 한 번씩 확인 부탁드립니다!
📋 To Do