Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Immer을 사용한 코드 구조 개선 #495

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

jinyoung234
Copy link
Contributor

@jinyoung234 jinyoung234 commented Oct 3, 2024

✅ 작업 내용

  • useTravelogueDays 로직 구조 개선
  • useTravelPlanDays 로직 구조 개선
  • query(usePostTravelogue, usePutTravelogue) 구조 개선

📸 스크린샷

x

🙈 참고 사항

  • 타입 변경한 부분(TraveloguePayload, TravelTransformDays) 있으니 참고부탁드려요!

Copy link

github-actions bot commented Oct 3, 2024

Test Results

11 tests  ±0   11 ✅ ±0   13s ⏱️ ±0s
 2 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 67b6da3. ± Comparison against base commit 08c0a1d.

@jinyoung234 jinyoung234 added this to the sprint 6 milestone Oct 3, 2024
Copy link

@simorimi simorimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

immer를 사용해서 가독성 좋게 수정하셨다는게 보이네요!
작업하느라 고생하셨습니다!
개인적으로 immer 공부가 필요하다는 생각이 드네요.. 언제까지 미루려나..

@@ -217,7 +217,7 @@ const TravelogueRegisterPage = () => {
iconType="plus"
position="left"
css={S.addButtonStyle}
onClick={() => onAddDay()}
onClick={onAddDay}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 부분들 다 해당 방식으로 통일하면 좋을 거 같다고 생각했는데 좋네요!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 앞으로 구현,리팩토링부분에서 이부분 보이면 이렇게 수정해야겠네욥

Copy link

@0jenn0 0jenn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 훨씬 깔끔해졌네요
고생하셨습니다 지니!

@@ -217,7 +217,7 @@ const TravelogueRegisterPage = () => {
iconType="plus"
position="left"
css={S.addButtonStyle}
onClick={() => onAddDay()}
onClick={onAddDay}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 앞으로 구현,리팩토링부분에서 이부분 보이면 이렇게 수정해야겠네욥

@jinyoung234 jinyoung234 merged commit 33aeb8a into develop/fe Oct 7, 2024
3 checks passed
@hangillee hangillee deleted the feature/fe/#492 branch October 11, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants