-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Immer을 사용한 코드 구조 개선 #495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
immer를 사용해서 가독성 좋게 수정하셨다는게 보이네요!
작업하느라 고생하셨습니다!
개인적으로 immer 공부가 필요하다는 생각이 드네요.. 언제까지 미루려나..
@@ -217,7 +217,7 @@ const TravelogueRegisterPage = () => { | |||
iconType="plus" | |||
position="left" | |||
css={S.addButtonStyle} | |||
onClick={() => onAddDay()} | |||
onClick={onAddDay} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 부분들 다 해당 방식으로 통일하면 좋을 거 같다고 생각했는데 좋네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 앞으로 구현,리팩토링부분에서 이부분 보이면 이렇게 수정해야겠네욥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드가 훨씬 깔끔해졌네요
고생하셨습니다 지니!
@@ -217,7 +217,7 @@ const TravelogueRegisterPage = () => { | |||
iconType="plus" | |||
position="left" | |||
css={S.addButtonStyle} | |||
onClick={() => onAddDay()} | |||
onClick={onAddDay} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 앞으로 구현,리팩토링부분에서 이부분 보이면 이렇게 수정해야겠네욥
✅ 작업 내용
📸 스크린샷
x
🙈 참고 사항