Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - health checker api 로깅 필터 안거치게 변경 #498

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Feature] - health checker api 로깅 필터 안거치게 변경 #498

merged 1 commit into from
Oct 4, 2024

Conversation

eunjungL
Copy link

@eunjungL eunjungL commented Oct 4, 2024

✅ 작업 내용

  • health checker api 로깅 필터 안거치게 변경

@eunjungL eunjungL added the BE label Oct 4, 2024
@eunjungL eunjungL added this to the sprint 6 milestone Oct 4, 2024
@eunjungL eunjungL self-assigned this Oct 4, 2024
@eunjungL eunjungL linked an issue Oct 4, 2024 that may be closed by this pull request
[Feature] - health checker api 로깅 필터 안거치게 변경 #491
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Test Results

 31 files   31 suites   8s ⏱️
266 tests 266 ✅ 0 💤 0 ❌
278 runs  278 ✅ 0 💤 0 ❌

Results for commit 2afb169.

Libienz
Libienz approved these changes Oct 4, 2024
View reviewed changes
Copy link

@Libienz Libienz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 화이트리스트를 상수로 관리하지 않는 것도 확인했습니다~

nak-honest
nak-honest approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@nak-honest nak-honest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml에서 받기 위해 생성자에서 화이트 리스트 받는 것 확인했습니다!
LGTM 입니닷

@eunjungL eunjungL merged commit 9099b9a into develop/be Oct 4, 2024
3 checks passed
@eunjungL eunjungL deleted the feature/be/#491 branch October 4, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Libienz Libienz Libienz approved these changes

@nak-honest nak-honest nak-honest approved these changes

@hangillee hangillee Awaiting requested review from hangillee

@slimsha2dy slimsha2dy Awaiting requested review from slimsha2dy

Assignees

@eunjungL eunjungL

Labels
BE
Projects
2024-touroot
Status: Done
Milestone
sprint 6
Development

Successfully merging this pull request may close these issues.

[Feature] - health checker api 로깅 필터 안거치게 변경
3 participants
@eunjungL @Libienz @nak-honest