[3주차] Wordle 과제 제출 - 김민수 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserWord Refactoring, 비기능 요구사항 추가
wip: GameManager
feat: Judgement 기능 구현
| } | ||
|
|
||
| private static void validate(String value) throws IllegalArgumentException { | ||
| if(value.length()!=5) { |
There was a problem hiding this comment.
단어의 길이는 하드코딩보다는 상수로 빼는 걸 고려해보시면 어떨까요?
| while (line != null) { | ||
| listOfLines.add(line); | ||
| line = bufferedReader.readLine(); | ||
| } |
There was a problem hiding this comment.
파일의 라인을 읽어와서 List으로 받으실 때 Files.lines() 같은 것도 있으니 찾아보시면 좋을 것 같습니다:)
|
|
||
| public class JudgeResult { | ||
|
|
||
| Color[] result; |
| for (int i = 0; i < PROGRESS_COUNT; i++) { | ||
| UserWord userWord = userInput.execute(); | ||
| JudgeResult judgeResult = judgement.execute(answer, userWord.getValue()); | ||
| printer.execute(judgeResult); |
There was a problem hiding this comment.
이전 결과도 함께 나타내야하는데, 이전 결과를 보관하는 곳이 있으면 어떨까요?
Comment on lines
+17
to
+19
| getGreenResult(answer, input, check, result); | ||
| getYellowResult(answer, input, check, result); | ||
| getGrayResult(check, result); |
There was a problem hiding this comment.
정답 비교 과정을 3개의 메서드로 깔끔하게 잘 분리하셨네요!👍
| @@ -0,0 +1,17 @@ | |||
| package wordle.vo; | |||
|
|
|||
| public enum Color { | |||
There was a problem hiding this comment.
타일색상에 대한 책임을 enum class로 잘 도출하셨네요!👍
Comment on lines
+13
to
+15
| private static final String OPENING_PHRASE = "WORDLE을 6번 만에 맞춰 보세요.\n시도의 결과는 타일의 색 변화로 나타납니다."; | ||
| private static final String CLOSING_PHRASE = "정답입니다 짝짝짝"; | ||
| private static final int PROGRESS_COUNT = 6; |
|
끝까지 구현하시느라 수고 많으셨습니다! |
minsoozz
commented
May 14, 2022
| for (int i = 0; i < PROGRESS_COUNT; i++) { | ||
| UserWord userWord = userInput.execute(); | ||
| JudgeResult judgeResult = judgement.execute(answer, userWord.getValue()); | ||
| printer.execute(judgeResult); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.