Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5기]3주차 Wordle 과제 제출 - 치즈 #30
base: main
Are you sure you want to change the base?
[5기]3주차 Wordle 과제 제출 - 치즈 #30
Changes from all commits
5d78aa1
0f37271
152e102
a2f92be
e7d01ae
a20cbf5
ca477cc
2249453
8f522ab
278f963
e29c493
ec19ce4
6d576d0
9ca1628
c06266b
e945ca1
5c2c650
1dffe39
751cb85
aba19f3
3b862be
e3592ae
c1b4bb9
bb20d2e
5af5e3a
52db4de
c1944e5
386e974
f59a5ef
5e87483
c69c28a
26942b5
d3e012a
c7310bb
a0e0221
8e0fcb2
f7ee01e
02fd48e
1f0c3a3
30b37aa
e54383b
0326777
8c5cc2c
a94f775
71d346d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
불변 객체 좋네요👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
딱구님과 제가 이쪽 로직에서 countPerCharacter가 Answer의 멤버로 포함되어 있고, 단순히 getter만 제공하고 있는 구조라서 counterPerCharacter가 Answer 내부에 있는게 옳은 방향인가 고민하다가 클래스를 분리했었는데요.
이 부분을 어떤 논의 과정으로 설계, 구현하셨는지 궁급합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 깊게 고민하지 않았는데, 말씀을 들어보니 Answer 내부에 countPerCharacter가 있는 게 아주 매끄럽지는 못하군요 🤔
저도 어떻게 풀어나가야 할 지 고민해봤는데 명쾌한 답을 아직 못 찾았습니다 ..
싸무엘님과 딱구님은 어떤 과정으로 클래스를 분리하셨을까요 ~?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희도 동일한 부분에서 어색하다고 느껴서 분리의 목적으로 countPerCharacter 에 관련된 책임을 갖는 Counter라는 클래스를 만들었어요.
단어의 문자를 비교할 때 count 관련한 기능은 해당 클래스가 담당하도록 했고, 비즈니스 로직에서 Answer와 Counter를 조합해서 문제를 풀어나가면 되지 않을까 생각했던 것 같아요.
100% 명쾌하게 해결한 것인지는 모르겠어서 저도 고민이 더 필요한 부분이긴 해요 ㅎㅎ 다른 분들의 문제 해결 과정도 궁금해지네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordleGameConfig 클래스가 게임 규칙 관련한 상수를 모아놓은 역할이라고 이해했어요.
그래서 이 상수도 게임 규칙 관련한거라 WordleGameConfig 에 포함되면 좋을 것 같다고 생각하는데, 혹시 WordleGameConfig에서 관리하지 않고 따로 분리하신 이유가 있을까요?? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다 ! 👍 정확히 표현하자면 WorldeGameConfig는 클라이언트 단에 즉각적으로 변화가 생길 수 있는 게임 규칙의 역할로 설계했어요.
이 상수도 고민이 많았지만, 오늘 날짜와 차이를 비교해서 정답을 도출해내는 도구에 국한된다고 생각해서 AnswerProvider에 있는게 맞다고 생각했습니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 저는 이런 부분들이 모두 게임의 규칙이라고만 생각했었는데,, 구체적으로 답변 주셔서 감사합니다 😄