-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish m2 to m3 conversion #21583
Finish m2 to m3 conversion #21583
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21583 +/- ##
=======================================
Coverage 39.48% 39.48%
=======================================
Files 2117 2117
Lines 99464 99464
Branches 15296 15296
=======================================
Hits 39269 39269
Misses 56714 56714
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @dcalhoun - I know this was a tedious one! I checked and all of those oddities exist in |
@@ -79,7 +79,7 @@ | |||
<issue id="IconDensities" severity="warning" /> <!-- fluxc--> | |||
<!-- INTEROPERABILITY --> | |||
<!-- TODO: https://github.com/wordpress-mobile/WordPress-Android/issues/21065 --> | |||
<issue id="UsingMaterialAndMaterial3Libraries" severity="warning" /> | |||
<issue id="UsingMaterialAndMaterial3Libraries" severity="error" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @nbradbury and awesome job with all this! ❤️
About switching from warning
to error
, just because this UsingMaterialAndMaterial3Libraries check is of Warning
severity by default, but we are anyway treating all warning as errors (WordPress/build.gradle#L317), I would recommend deleting this whole configuration and its comment (#21065), doing that we will end-up with the same result.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes #21065 - As mentioned on pbArwn-6XC-p2#comment-8241, the conversion from Material 2 (M2) to Material 3 (M3) was incomplete. This PR addresses all the remaining issues.
As part of this, I changed
lint.xml
so thatUsingMaterialAndMaterial3Libraries
is treated as an error rather than a warning. This waylint
will fail if we accidentally introduce M2 components in the future.Testing isn't straightforward because this affected so many areas, none of which were really large enough to warrant separate PRs. Also, many of the changes involved reusable components such
MainTopAppBar
which are used throughout the app. My recommendation is to first ensurelint
passes, then smoke test the app and verify nothing looks out of whack.That said, the areas most impacted by these changes - and therefore needing the most testing - are:
That last one is tricky to test, so here's a screenshot of the updated conflict dialog:
Social sharing is likewise tricky to test because setting up social connections appears to be broken.