Fix Zendesk contact support overlap for Android 15 (SDK 35) #21617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21617-11e08fc | |
| Commit | 11e08fc | |
| Direct Download | wordpress-prototype-build-pr21617-11e08fc.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21617-11e08fc | |
| Commit | 11e08fc | |
| Direct Download | jetpack-prototype-build-pr21617-11e08fc.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21617 +/- ##
=======================================
Coverage 39.44% 39.44%
=======================================
Files 2119 2119
Lines 99485 99485
Branches 15308 15308
=======================================
Hits 39246 39246
Misses 56760 56760
Partials 3479 3479 ☔ View full report in Codecov by Sentry. |
|
nbradbury
changed the title
dcalhoun
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21616
After updating to Android 15's edge-to-edge support, we noticed the message field at the bottom of Zendesk's WebView-based "Contact support" screen overlapped the bottom navigation bar and wasn't tappable, as shown below:
This PR addresses the problem by ignoring edge-to-edge for that specific activity:
I also added some minor cleanup to our previous edge-to-edge support.
Note that if you see the suggested questions overlapping as in the screenshot below, this is a long-standing issue with Zendesk and isn't caused by this PR.