[Tests] Fix Android Tests Compilation Failure #21627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to Zendesk 5.3.0 comes with singificant changes in the Zendesk SDK structure and naming conventions. This cause an issue with the 'com.zendesk.sdk.R' import that was no longer resolvable. Updating the import to 'zendesk.support.R' solves this issue. For more info see: - 5.3.0: https://developer.zendesk.com/documentation/classic-web-widget-sdks/ support-sdk/android/release_notes/#530 - Migration from Classic SDKs to Zendesk SDK: https://developer.zendesk.com/documentation/zendesk-web-widget-sdks/ sdks/android/migration/#migration-from-classic-sdks-to-zendesk-sdk
|
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21627-a7868af | |
| Commit | a7868af | |
| Direct Download | wordpress-prototype-build-pr21627-a7868af.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21627-a7868af | |
| Commit | a7868af | |
| Direct Download | jetpack-prototype-build-pr21627-a7868af.apk |
wzieba
approved these changes
Jan 28, 2025
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
com.zendesk.sdkimport withzendesk.supportto resolve R.Updating to Zendesk
5.3.0(done as part of #21607) comes with significant changes in the Zendesk SDK structure and naming conventions. This cause an issue with thecom.zendesk.sdk.Rimport that was no longer resolvable. Updating the import tozendesk.support.Rsolves this issue.For more info see:
To Test:
Run both the below Gradle tasks locally and make sure they complete successfully:
./gradlew assembleJetpackJalapenoDebugAndroidTest(for dependency cache purposes - related build failure)./gradlew buildHealth(for dependency analysis purposes - related build failure)Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above`What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): N/A