Fix crash in a GIFAnimatedImage extension (#24031)

wordpress-mobile · Jan 30, 2025 · a6875ba · a6875ba
1 parent 76a3cd4
commit a6875ba
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/Modules/Sources/AsyncImageKit/Views/AsyncImageView.swift b/Modules/Sources/AsyncImageKit/Views/AsyncImageView.swift
@@ -47,7 +47,7 @@ public final class AsyncImageView: UIView {
             if let image {
                 imageView.configure(image: image)
             } else {
-                imageView.prepareForReuse()
+                imageView.reset()
             }
         }
     }
@@ -185,7 +185,7 @@ extension GIFImageView {
         }
     }
 
-    public func prepareForReuse() {
+    public func reset() {
         if isAnimatingGIF {
             prepareForReuse()
         } else {

diff --git a/Modules/Sources/AsyncImageKit/Views/UIImageView+ImageDownloader.swift b/Modules/Sources/AsyncImageKit/Views/UIImageView+ImageDownloader.swift
@@ -14,7 +14,7 @@ public struct ImageViewExtensions {
         controller.prepareForReuse()
 
         if let gifView = imageView as? GIFImageView, gifView.isAnimatingGIF {
-            gifView.prepareForReuse()
+            gifView.reset()
         } else {
             imageView.image = nil
         }

diff --git a/WordPress/Classes/ViewRelated/Media/SiteMedia/Views/SiteMediaCollectionCell.swift b/WordPress/Classes/ViewRelated/Media/SiteMedia/Views/SiteMediaCollectionCell.swift
@@ -68,7 +68,7 @@ final class SiteMediaCollectionCell: UICollectionViewCell, Reusable {
         viewModel?.onDisappear()
         viewModel = nil
 
-        imageView.prepareForReuse()
+        imageView.reset()
         imageView.image = nil
         imageView.alpha = 0
 

diff --git a/WordPress/Classes/ViewRelated/Media/SiteMedia/Views/SiteMediaImageView.swift b/WordPress/Classes/ViewRelated/Media/SiteMedia/Views/SiteMediaImageView.swift
@@ -53,7 +53,7 @@ final class SiteMediaImageView: UIView {
             if let image {
                 imageView.configure(image: image)
             } else {
-                imageView.prepareForReuse()
+                imageView.reset()
             }
         }
     }

diff --git a/WordPress/Classes/ViewRelated/Views/RichTextView/AnimatedGifAttachmentViewProvider.swift b/WordPress/Classes/ViewRelated/Views/RichTextView/AnimatedGifAttachmentViewProvider.swift
@@ -11,8 +11,7 @@ class AnimatedGifAttachmentViewProvider: NSTextAttachmentViewProvider {
         guard let animatedImageView = view as? GIFImageView else {
             return
         }
-
-        animatedImageView.prepareForReuse()
+        animatedImageView.reset()
     }
 
     override init(textAttachment: NSTextAttachment, parentView: UIView?, textLayoutManager: NSTextLayoutManager?, location: NSTextLocation) {