-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Uploader protocol in MediaCoordinator and PostCoordinator. #11839
Implements Uploader protocol in MediaCoordinator and PostCoordinator. #11839
Conversation
Generated by 🚫 dangerJS |
Hey @diegoreymendez, wonderful work here! Test 2: |
Diego, have you looked into using NWPathMonitor from Apple's Network framework? |
Only available in iOS 12 or newer, which makes it a no-go :( One other option is probably this but I'd like to keep that as a separate task since I think fixing reachability is beyond the scope of this specific PR. I've opened this issue for it: #11840 |
@yaelirub - Awesome feedback... I've opened a new issue to tackle that problem separately here: #11846. I've decided to split it because it's going to be easier for me to make progress on this incrementally, and because this issue is only present in the feature branch. Rest assured we'll make sure everything is working before merging the feature branch. Thanks for the review! |
|
||
private func setupReachableBlock() { | ||
reachability.reachableBlock = { _ in | ||
self.resume() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a weak self?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Will submit a PR to fix.
Fixes #11785
Fixes #11784
Implements the Uploader protocol in both coordinator, and wires it so that it's triggered when the App is opened, when it comes to foreground, and when
Reachability
detects there's a connection.Update release notes:
RELEASE-NOTES.txt
.Known Issues / Scope limitations:
Reachability isn't working very well, but from my investigation this is not related to my PR. Reachability is simply failing to call the closures it should call.
I'll need to investigate this separately, as it goes beyond the scope of this specific PR.
Testing:
Test 1:
Test 2: