Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct wpxmlrpc usages from the app #23389

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 26, 2024

The wpxmlrpc was another transient dependency declared in WordPressKit.podspec but used directly from the app. WordPressKit now re-export the only property from wpxmlrpc that was used by the app.

If we end up using Xcode targets to define WordPressKit, we'll include it as a Swift package and link it statically in WordPressKit. Either way, it's one less dependency to worry about.

To test:

Just to make sure it works, I span a local WP instance and changes a password:

Not sure what's up with "Updating..." in the background. I left a note to check it later.

Screenshot 2024-06-26 at 3 26 50 PM

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the Pending milestone Jun 26, 2024
@kean kean requested a review from jkmassel June 26, 2024 19:34
@kean kean force-pushed the task/remove-wpxmlrpc-usages branch from d5708ed to 16ac4cd Compare June 26, 2024 19:35
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23389-16ac4cd
Version25.1
Bundle IDorg.wordpress.alpha
Commit16ac4cd
App Center BuildWPiOS - One-Offs #10230
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23389-16ac4cd
Version25.1
Bundle IDcom.jetpack.alpha
Commit16ac4cd
App Center Buildjetpack-installable-builds #9279
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants