Remove direct wpxmlrpc usages from the app #23389
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wpxmlrpc
was another transient dependency declared inWordPressKit.podspec
but used directly from the app.WordPressKit
now re-export the only property fromwpxmlrpc
that was used by the app.If we end up using Xcode targets to define
WordPressKit
, we'll include it as a Swift package and link it statically inWordPressKit
. Either way, it's one less dependency to worry about.To test:
Just to make sure it works, I span a local WP instance and changes a password:
Not sure what's up with "Updating..." in the background. I left a note to check it later.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: