Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Remove ReaderFollowedSitesViewController #23756

Open
wants to merge 2 commits into
base: fix/bottom-insets-stream
Choose a base branch
from

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 1, 2024

  • Remove ReaderFollowedSitesViewController that we no longer use
  • Remove one more downloadSiteIcon(for:) usage/variant. The last usages were in ReaderFollowedSitesViewController and PrepublishingHeaderView. I updated the later.
Screenshot 2024-11-01 at 5 22 42 PM Screenshot 2024-11-01 at 5 35 53 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Nov 1, 2024
@kean kean added this to the 25.5 milestone Nov 1, 2024
@kean kean requested a review from crazytonyli November 1, 2024 21:39
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants