-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move users to a new WordPressCore module #24014
Conversation
Generated by 🚫 Danger |
Any plans for the Core Data entities and the related services? The name seems OK. |
A Core Data-based |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
The name WordPressUITests conflicts with the name of WordPress target's UI Tests target
@@ -86,7 +86,7 @@ let package = Package( | |||
]), | |||
.testTarget(name: "WordPressSharedTests", dependencies: [.target(name: "WordPressShared")], swiftSettings: [.swiftLanguageMode(.v5)]), | |||
.testTarget(name: "WordPressSharedObjCTests", dependencies: [.target(name: "WordPressShared"), .target(name: "WordPressTesting")], swiftSettings: [.swiftLanguageMode(.v5)]), | |||
.testTarget(name: "WordPressUITests", dependencies: [.target(name: "WordPressUI")], swiftSettings: [.swiftLanguageMode(.v5)]), | |||
.testTarget(name: "WordPressUIUnitTests", dependencies: [.target(name: "WordPressUI")], swiftSettings: [.swiftLanguageMode(.v5)]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how this was ambiguous.
This PR is not buildable yet (pending a wordpress-rs alpha release)Update: this PR now uses the latest wordpress-rs alpha version. But the changes are fairly simple. I thought we could get the changes reviewed while waiting for the alpha release.This PR moves the non-UI part of self-hosted user management and some foundational things it uses to a new module
WordPresCore
, which includes strict concurrency checks. The new module will include components communicating with WordPress sites via REST API in WordPress core (hence the name). I'm open to suggestions of better module names.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: