Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move users to a new WordPressCore module #24014

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Jan 27, 2025

This PR is not buildable yet (pending a wordpress-rs alpha release) Update: this PR now uses the latest wordpress-rs alpha version. But the changes are fairly simple. I thought we could get the changes reviewed while waiting for the alpha release.

This PR moves the non-UI part of self-hosted user management and some foundational things it uses to a new module WordPresCore, which includes strict concurrency checks. The new module will include components communicating with WordPress sites via REST API in WordPress core (hence the name). I'm open to suggestions of better module names.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli requested review from jkmassel and kean January 27, 2025 02:18
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 27, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean
Copy link
Contributor

kean commented Jan 27, 2025

This PR moves the non-UI part of self-hosted user management and some foundational things it uses to a new module WordPresCore, which includes strict concurrency checks. The new module will include components communicating with WordPress sites via REST API in WordPress core (hence the name). I'm open to suggestions of better module names.

Any plans for the Core Data entities and the related services?

The name seems OK.

@jkmassel
Copy link
Contributor

Any plans for the Core Data entities and the related services?

A Core Data-based DataStore would be pretty easy to implement – that could be part of this module, or could be implemented elsewhere. This PR is a good start from migrating away from Core Data where it's not needed

@crazytonyli crazytonyli self-assigned this Jan 28, 2025
@crazytonyli crazytonyli added this to the 25.8 milestone Jan 28, 2025
@crazytonyli crazytonyli marked this pull request as ready for review January 28, 2025 00:59
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 28, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24014-9ec4ada
Version25.7
Bundle IDorg.wordpress.alpha
Commit9ec4ada
App Center BuildWPiOS - One-Offs #11412
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 28, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24014-9ec4ada
Version25.7
Bundle IDcom.jetpack.alpha
Commit9ec4ada
App Center Buildjetpack-installable-builds #10444
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

The name WordPressUITests conflicts with the name of WordPress target's
UI Tests target
@@ -86,7 +86,7 @@ let package = Package(
]),
.testTarget(name: "WordPressSharedTests", dependencies: [.target(name: "WordPressShared")], swiftSettings: [.swiftLanguageMode(.v5)]),
.testTarget(name: "WordPressSharedObjCTests", dependencies: [.target(name: "WordPressShared"), .target(name: "WordPressTesting")], swiftSettings: [.swiftLanguageMode(.v5)]),
.testTarget(name: "WordPressUITests", dependencies: [.target(name: "WordPressUI")], swiftSettings: [.swiftLanguageMode(.v5)]),
.testTarget(name: "WordPressUIUnitTests", dependencies: [.target(name: "WordPressUI")], swiftSettings: [.swiftLanguageMode(.v5)]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how this was ambiguous.

@crazytonyli crazytonyli added this pull request to the merge queue Jan 29, 2025
Merged via the queue into trunk with commit a0d6a8f Jan 29, 2025
25 checks passed
@crazytonyli crazytonyli deleted the move/users-to-module branch January 29, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants