Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress-iOS Edition #815

Closed
wants to merge 13 commits into from
Closed

WordPress-iOS Edition #815

wants to merge 13 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Jul 12, 2024

This PR adds a script to build WordPressKit as a binary framework and link the dependencies statically. It also inlines the WordPressShared code, prefixing the Objective-C APIs, and removes UIDeviceIdentifier.

Next steps: inline NSObject_SafeExpectations. wpxmlrpc is OK to link statically because it should be a private dependency.

Fixes #

ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.

Testing Details

ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Jul 12, 2024

Danger has errored

[!] Invalid Dangerfile file: No such file or directory @ rb_sysopen - ./Podfile.lock

 #  from Dangerfile:10
 #  -------------------------------------------
 #  
 >  podfile_checker.check_podfile_does_not_have_branch_references
 #  
 #  -------------------------------------------

Generated by 🚫 Danger

@kean kean changed the title [Experimental] XCFramework WordPress-iOS Edition Jul 12, 2024
@kean kean closed this Jul 12, 2024
@kean kean deleted the task/experimental-xcframework branch July 12, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants