Fix crash when starting a request on an invalidated session #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
force-pushed
the
fix/crash-on-invalidate
branch
2 times, most recently
from
b187132 to
df614dc
Compare
kean
force-pushed
the
fix/crash-on-invalidate
branch
from
df614dc to
fede7bd
Compare
Generated by 🚫 Danger |
kean
force-pushed
the
fix/crash-on-invalidate
branch
from
a8c0029 to
fede7bd
Compare
kean
changed the title
crazytonyli
reviewed
Feb 3, 2025
| @@ -105,6 +105,8 @@ open class WordPressComRestApi: NSObject { | |||
|
|
|||
| private var useEphemeralSession: Bool | |||
|
|
|||
| private var isInvalidated = false | |||
There was a problem hiding this comment.
What do you think about changing those URLSession properties to Optional instead and assigning them to nil in the invalidateAndCancelTasks function?
crazytonyli
reviewed
Feb 3, 2025
| @@ -202,6 +208,7 @@ open class WordPressComRestApi: NSObject { | |||
| success: @escaping SuccessResponseBlock, | |||
| failure: @escaping FailureReponseBlock) -> Progress? { | |||
| let progress = Progress.discreteProgress(totalUnitCount: 100) | |||
| print("GET:", Thread.callStackSymbols) | |||
There was a problem hiding this comment.
Remove the print statements before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.
Testing Details
ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.
CHANGELOG.mdif necessary.