Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split demos into types & Add search to ComboRow #67

Closed
wants to merge 0 commits into from

Conversation

Sahil-Shadwal
Copy link
Contributor

@Sahil-Shadwal Sahil-Shadwal commented Feb 1, 2024

#65
Separated the various demos into types cause it was showcasing too many things. And added main.js for enabling search to the ComboRow

@Sahil-Shadwal Sahil-Shadwal requested a review from sonnyp as a code owner February 1, 2024 10:51
@Sahil-Shadwal
Copy link
Contributor Author

Screencast.from.2024-02-04.18-19-54.webm

XML code works, because of these lines
<property name="expression"> <lookup type="GtkStringObject" name="string"/> </property>
But wasn't able to replicate these lines to blueprint .

@Sahil-Shadwal Sahil-Shadwal changed the title Divided demos into types Split demos into types & Add search to ComboRow Feb 7, 2024
@sonnyp
Copy link
Contributor

sonnyp commented Feb 11, 2024

I'll need some time to think about what we want to do for #65
I had in mind to have one demo per row type but it might be too much

@Sahil-Shadwal avoid using your main branch for submitting PRs - it's easier if it tracks Workbench main.

If you want you can file a new PR for

Add search to the ComboRow demo

I think that should be straightforward

@Sahil-Shadwal
Copy link
Contributor Author

Yes sir :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants