Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots #20

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Screenshots #20

merged 2 commits into from
Jan 10, 2024

Conversation

PaulAsjes
Copy link
Contributor

@PaulAsjes PaulAsjes commented Jan 10, 2024

Updated README to have screenshots and reworked instructions slightly. Fixes #19

Updated README to have screenshots, reworked instructions and bumped workos-node to the latest version v5.0.0.
README.md Outdated
Comment on lines 10 to 13
<p align="center">
<img alt="Screenshot of hosted UI AuthKit in dark mode" src="https://github.com/workos/authkit/assets/108872335/e6e44a30-3ec6-4385-95bd-07709e20e10a" width="45%">
&nbsp; &nbsp; &nbsp; &nbsp;
<img alt="Screenshot of hosted UI AuthKit in light mode" src="https://github.com/workos/authkit/assets/108872335/08ea6ecb-6749-4b31-89d4-49f59321aff7" width="45%">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about:

  • Lead with a single light mode screenshot so it doesn't feel repetitive
  • Limiting the OAuth methods to Google and Microsoft so the screen feels a bit more focused—not sure we should showcase every method we have because it will just keep growing
  • I’d consider dropping the WorkOS logo and keep the default black button style so that it doesn’t feel like you are going to have WorkOS branding. We could use a sample logo from https://workos.com/user-management
  • Should we show a bit more of the padding on the image so it doesn’t feel as zoom in? I think GitHub displays images up to 800px wide before it starts scaling it

```
## Running the example

1. Install dependencies with `npm install` or `yarn install`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With yarn you can just do yarn without install—although not sure whether we want to mention yarn at all given how popular the alternative package managers have become

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that, but for new developers it might not be obvious enough that these do the same thing.

In terms of alternative package managers, I think yarn and npm are ubiquitous enough to get a mention while the others haven't hit that critical mass yet. Either way I don't think it'll hurt to have both npm and yarn here.

@PaulAsjes PaulAsjes merged commit 7761c7e into main Jan 10, 2024
@PaulAsjes PaulAsjes deleted the paulasjes/update-readme branch January 10, 2024 14:18
@corysimmons
Copy link

This is fine, but I could see the gist of the login panel already.

#19 was mostly brought up because I was curious about what your avatar dropdown and profile page/modal looked like.

image

@benoitgrelard
Copy link
Contributor

Hi! We don't currently have components for those, hence why only those screenshots for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots?
4 participants