Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI badge + add NuGet one #172

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix CI badge + add NuGet one #172

merged 1 commit into from
Jul 16, 2024

Conversation

gcarvelli
Copy link
Contributor

@gcarvelli gcarvelli commented Jul 15, 2024

Description

Replace the Semaphore badge with a Github Actions badge and add a NuGet badge to match our other repos.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@gcarvelli gcarvelli self-assigned this Jul 15, 2024
@gcarvelli gcarvelli requested a review from a team as a code owner July 15, 2024 18:28
@gcarvelli gcarvelli requested a review from jasonroelofs July 15, 2024 18:28
- [Single Sign-On Guide](https://workos.com/docs/sso/guide)
- [Directory Sync Guide](https://workos.com/docs/directory-sync/guide)
- [Admin Portal Guide](https://workos.com/docs/admin-portal/guide)
- [Magic Link Guide](https://workos.com/docs/magic-link/guide)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My auto-formatter caught this. Seems like a safe change. We don't upload this README to NuGet, it's strictly for the GitHub repo.

@@ -1,6 +1,7 @@
# WorkOS .NET Library

[![Build Status](https://workos.semaphoreci.com/badges/workos-dotnet/branches/main.svg?style=shields&key=343c1d18-79da-4ea3-89ce-8a6195a9d3d9)](https://workos.semaphoreci.com/projects/workos-dotnet)
[![Packagist Version](https://img.shields.io/nuget/v/WorkOS.net)](https://www.nuget.org/packages/WorkOS.net)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a link to the package. In most of our repos it's just a link to the image (see workos-php)

I'll go through and fix those at some point.

@gcarvelli gcarvelli merged commit 4751f31 into main Jul 16, 2024
3 checks passed
@gcarvelli gcarvelli deleted the gio/fix-badge branch July 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants