Skip to content

Commit

Permalink
chore(deps): JIRA-9008 Remove deprecated package
Browse files Browse the repository at this point in the history
Updates the various `symplify` packages, which in turn removes the dependency on `symplify/composer-json-manipulator`, which is now deprecated. Also adds a docker configuration for quickly being able to begin developing on the package locally.
  • Loading branch information
lukeraymonddowning committed Jan 27, 2023
1 parent ee1d03c commit a14e973
Show file tree
Hide file tree
Showing 8 changed files with 39 additions and 21 deletions.
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ phpcs.xml export-ignore
phpstan.neon export-ignore
phpunit.xml export-ignore
rector.php export-ignore
docker export-ignore
docker-compose.yml export-ignore
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,13 @@ return function (ContainerConfigurator $config): void {
]);
};
```

## Testing

This package ships with a docker configuration for running the tests.
Assuming you have cloned the repository and have docker and docker-compose installed, you can run the tests by running

```bash
docker-compose run --rm composer install # Only needed the first time
docker-compose run --rm pest
```
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
"symfony/dependency-injection": "^6.0",
"symfony/http-kernel": "^6.0",
"symfony/config": "^6.0",
"symplify/autowire-array-parameter": "^10.0",
"symplify/package-builder": "^10.2",
"symplify/autowire-array-parameter": "^11.0",
"symplify/package-builder": "^11.0",
"thecodingmachine/safe": "^2.2"
},
"require-dev": {
"pestphp/pest": "^1.21",
"symfony/var-dumper": "^6.0",
"symplify/easy-testing": "^10.0",
"symplify/easy-testing": "^11.0",
"worksome/coding-style": "^2.0.0",
"pestphp/pest-plugin-parallel": "^1.1"
},
Expand Down
17 changes: 17 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
version: "3.8"

services:
php:
build: ./docker
volumes:
- .:/var/www/html
pest:
build: ./docker
entrypoint: ["php", "./vendor/bin/pest"]
volumes:
- .:/var/www/html
composer:
build: ./docker
entrypoint: ["composer"]
volumes:
- .:/var/www/html
7 changes: 7 additions & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
FROM php:8.2-cli-alpine

COPY --from=composer:2 /usr/bin/composer /usr/bin/composer

WORKDIR /var/www/html

ENTRYPOINT ["php"]
16 changes: 0 additions & 16 deletions phpstan-baseline.neon

This file was deleted.

1 change: 0 additions & 1 deletion phpstan.neon
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
includes:
- ./phpstan-baseline.neon
- ./vendor/worksome/coding-style/phpstan.neon

parameters:
Expand Down
1 change: 0 additions & 1 deletion src/Utils/NodeNameResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public function getName(?Node $node): ?string
return $node->value;
}

// @phpstan-ignore-next-line
if (! isset($node->name)) {
return null;
}
Expand Down

0 comments on commit a14e973

Please sign in to comment.