Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JIRA-14388 Add new DecimalTwo scalar #31

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

owenvoke
Copy link
Member

No description provided.

@owenvoke owenvoke requested a review from alberthaff February 14, 2025 09:53
@owenvoke owenvoke force-pushed the feature/decimal-scalar branch from c8f00a1 to 39e057a Compare February 14, 2025 09:59
Copy link

@alberthaff alberthaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we use return types instead of doc blocks?

@owenvoke
Copy link
Member Author

owenvoke commented Feb 14, 2025

Can do, I was just keeping it consistent with the underlying ScalarType. Added, and made the same changes to our other scalars.

@owenvoke owenvoke merged commit 8003582 into main Feb 14, 2025
11 checks passed
@owenvoke owenvoke deleted the feature/decimal-scalar branch February 14, 2025 10:51
@owenvoke owenvoke changed the title feat: add new DecimalTwo scalar feat: JIRA-14388 Add new DecimalTwo scalar Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants