Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data vis slides #123

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Updated data vis slides #123

merged 3 commits into from
Mar 6, 2024

Conversation

mfiorina
Copy link
Contributor

Changes made:

@ramarty
Copy link
Collaborator

ramarty commented Mar 6, 2024

  1. On slide 24, maybe add +geom_point(), just so its similar structure to next one and previous code.
  2. On slide 26, maybe simplify this: mutate(latam = ifelse(region == "Latin America and Caribbean", TRUE, FALSE)) to just mutate(region == "Latin America and Caribbean"). Although maybe a reason not to simplify?
  3. Not sure if there's a good way to fit this, but for changing scales, one thing that may be kinda common is to have a variable that is a proportion that you want to represent as a percent. Not sure if we can fit using this into an example: scale_y_continuous(labels = scales::percent) (or more simply could link to this as a resource maybe? https://thomasadventure.blog/posts/ggplot2-percentage-scale/)
  4. Maybe on additional thing that could be helpful to include is using scale_[x/y]_continuous to change breaks, labels, and range? For example, if data shows something from 0 to 70%, may want to change plot to show up to 100%. Also may want to reduce/increase number of labels. Although realize there's about 453,273 different things we can teach about ggplot so we need to limit -- but this potentially may be common-ish enough to reference?

@mfiorina
Copy link
Contributor Author

mfiorina commented Mar 6, 2024

Thank you @ramarty! I've implemented the following changes:

  • Corrected lack of geom_point() in slide 26
  • Implemented suggested change in slide 36
  • Could find a good use case with the current dataset for scales::percent, but something I'll keep in mind. Changed use of scale_log_10() to scale_x_continuous() which I agree is more commonly used and useful

@mfiorina mfiorina merged commit eccf006 into main Mar 6, 2024
@mfiorina mfiorina deleted the update-data-vis branch March 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

March 2023 - Data vis May 2022 - Data Visualization
2 participants