Code review checklists #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizaandrade
requested review from
kbjarkefur,
mariaruth,
luisesanmartin and
Avnish95
|
Thanks so much for sharing these suggestions, @luizaandrade! I'll take a look at these and add these to our checklists for the peer code review, |
luisesanmartin
requested review from
ankritisingh
and removed request for
Avnish95,
kbjarkefur,
mariaruth and
luisesanmartin
|
@ankritisingh can you check it first, reconcile the content and update what you consider in light of the new peer review workflow, and then tag Maria, Mer, Kristoffer, and I for review? thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, I was preparing some material for our next round of review here in Chicago and thought of these suggestions. I wasn't sure who should be tagged, so I added the same reviewers as the last PR.