Merge pull request #74 from worldbank/v1.1

v1.1
- corrected bug in function detecting if a line is closing a loop so that in can handle empty lines
- changed command version format from x.x.x to x.x
- updated name in acknowledgments

src/lint.ado

@@ -1,4 +1,4 @@
-*! version 1.0.0  06dec2022  DIME Analytics [email protected]
+*! version 1.1  07dec2022  DIME Analytics [email protected]
 
 capture program drop lint
 		program 	 lint
@@ -536,7 +536,7 @@ capture program drop _checkversions
 
 	* IMPORTANT: Every time we have a package update, update the version number here
 	* Otherwise we'd be introducing a major bug!
-	local version_ado 1.0.0
+	local version_ado 1.1
 
 	* Check versions of .py files
 	python: from sfi import Macro

src/lint.sthlp

@@ -1,5 +1,5 @@
 {smcl}
-{* 06 Dec 2022}{...}
+{* 07 Dec 2022}{...}
 {hline}
 help for {hi:lint}
 {hline}
@@ -227,7 +227,7 @@ for each bad practice detected:
 
 {phang}This work is a product of the initial idea and work of Mizuhiro Suzuki.
   Rony Rodriguez Ramirez, Luiza Cardoso de Andrade and Luis Eduardo San Martin also contributed to this command,
-  and Kristoffer Bjarkefur and Benjamin B. Daniels provided comments and code reviews.
+  and Kristoffer Bjärkefur and Benjamin B. Daniels provided comments and code reviews.
 
 {title:Authors}
 

src/stata_linter_correct.py

@@ -1,4 +1,4 @@
-# version 1.0.0  06dec2022  DIME Analytics [email protected]
+# version 1.1  07dec2022  DIME Analytics [email protected]
 # Import packages ============
 import os
 import re
@@ -8,7 +8,7 @@
 # Version Global
 ## VERY IMPORTANT: Update the version number here every time there's an update
 ## in the package. Otherwise this will cause a major bug
-VERSION = "1.0.0"
+VERSION = "1.1"
 
 # Function to update comment delimiter =============
 # (detection works only when comment delimiter == 0)

src/stata_linter_detect.py

@@ -1,4 +1,4 @@
-# version 1.0.0  06dec2022  DIME Analytics [email protected]
+# version 1.1  07dec2022  DIME Analytics [email protected]
 # Import packages ====================
 import os
 import re
@@ -9,7 +9,7 @@
 # Version Global
 ## VERY IMPORTANT: Update the version number here every time there's an update
 ## in the package. Otherwise this will cause a major bug
-VERSION = "1.0.0"
+VERSION = "1.1"
 
 # simple run entry point
 def run():
@@ -101,8 +101,15 @@ def loop_close(line):
     '''
     Detects if a line is closing a loop
     '''
-    if re.split('//', line)[0].rstrip()[-1] =='}':
-        return True
+    relevant_part = re.split('//', line)[0].rstrip()
+
+    if len(relevant_part) > 0:
+
+        if relevant_part[-1] =='}':
+            return True
+        else:
+            return False
+
     else:
         return False
 

src/stata_linter_utils.py

@@ -1,4 +1,4 @@
-# version 1.0.0  06dec2022  DIME Analytics [email protected]
+# version 1.1  07dec2022  DIME Analytics [email protected]
 # Import packages ====================
 import re
 import pandas as pd

stata.toc

@@ -1,3 +1,3 @@
-v 1.0.0
+v 1.1
 d DIME Analytics, World Bank Group, Development Economics Research
 p stata_linter

stata_linter.pkg

@@ -1,9 +1,9 @@
-v 1.0.0
+v 1.1
 d DIME Analytics, World Bank Group, Development Economics Research
 p stata_linter
 f /src/stata_linter_detect.py
 f /src/stata_linter_correct.py
 f /src/stata_linter_utils.py
 f /src/lint.ado
-f /help/lint.sthlp
+f /src/lint.sthlp
 e