Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aurel/graph_store: copy and adapt GraphPg #1002

Merged
merged 10 commits into from
Feb 9, 2025
Merged

aurel/graph_store: copy and adapt GraphPg #1002

merged 10 commits into from
Feb 9, 2025

Conversation

naure
Copy link
Collaborator

@naure naure commented Feb 3, 2025

No description provided.

@naure naure force-pushed the aurel/graph_store branch from ddd7af0 to 55c36f8 Compare February 5, 2025 13:51
@naure naure marked this pull request as ready for review February 5, 2025 14:10
@naure naure requested review from iliailia and siajasl February 5, 2025 14:11
Copy link
Collaborator

@iliailia iliailia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!


let ep = graph.get_entry_point().await;

let ep2 = EntryPoint {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you compare the content of ep with ep2 as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ep should be None so I added an assert.

@naure naure enabled auto-merge (squash) February 9, 2025 18:34
@naure naure merged commit c8c411a into main Feb 9, 2025
13 checks passed
@naure naure deleted the aurel/graph_store branch February 9, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants