-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aurel/persist-graph: Mutate the graph in the background thread #1025
base: main
Are you sure you want to change the base?
Conversation
Could you merge it with main to have a better view of relevant changes? |
add08c6
to
e5080b0
Compare
Done. |
/// Actor-specific data (e.g. graph mutations). | ||
pub actor_data: A, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, just a design question:
Should we aim for the db insertion stuff to also be internal to the actor? This again would now add code that is unique to the CPU impl to the server_hawk.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point to try to minimize change in server*.rs
. As it stands the GraphStore needs a plain old data structure from the Hawk search, but a complex interaction with the startup, database update, and crash recovery mechanisms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
Any opinions about this? |
Sounds like a good idea to me. It's a bit annoying to have both a graph and an iris store as arguments for any HNSW searcher method. Plus, semantically these two objects must relate to each other anyway. |
On top of #1023.
graph_id
).test_graph_migrations
).load_graph_store
).test_graph_load
).server_hawk.rs
.migrations
scripts).tx
inserver_hawk.rs
).