can: fix ack number with a high pid #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack number uses the pid in the 16 most significant bits (and a counter in the lower 16 bits), this allows us to filter out acks that are not for the current process. But, the pid can be encoded over more than 16 bits, so this fix allows the usage of the 16 lsb of the pid in the ack number, the msb of the pid are lost.
alekseifedotov
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ack number uses the pid in the 16 most significant bits (and a counter in the lower 16 bits),
this allows us to filter out acks that are not
for the current process.
But, the pid can be encoded over more than 16 bits, so this fix allows the usage of the 16 lsb of the pid in the ack number, the msb of the pid are lost.
fixes that bug where the ack got ignored because the pid is higher than
u16::MAX