Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(orb-info): FM-370-orb-info #366

Merged
merged 21 commits into from
Feb 14, 2025
Merged

feat(orb-info): FM-370-orb-info #366

merged 21 commits into from
Feb 14, 2025

Conversation

paulquinn00
Copy link
Contributor

@paulquinn00 paulquinn00 commented Feb 6, 2025 •
edited
Loading

Crate of helpers to retrieve common Orb info values.
Currently supported:

  • orb id
  • orb name
  • orb jabil id
  • orb auth token

Additionally:

  • Moved orb_endpoints::OrbId to orb_info::OrbId

@paulquinn00 paulquinn00 marked this pull request as ready for review February 6, 2025 12:11
@paulquinn00 paulquinn00 changed the title feat(orb-info) FM-370-orb-info feat(orb-info): FM-370-orb-info Feb 6, 2025
TheButlah
TheButlah requested changes Feb 11, 2025
View reviewed changes
orb-info/Cargo.toml Outdated Show resolved Hide resolved
orb-info/src/orb_id.rs Outdated Show resolved Hide resolved
orb-info/src/lib.rs Outdated Show resolved Hide resolved
orb-info/src/lib.rs Outdated Show resolved Hide resolved
orb-info/src/lib.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
TheButlah
TheButlah requested changes Feb 11, 2025
View reviewed changes
orb-info/src/lib.rs Outdated Show resolved Hide resolved
orb-info/src/lib.rs Outdated Show resolved Hide resolved
orb-info/src/orb_jabil_id.rs Outdated Show resolved Hide resolved
orb-info/src/orb_jabil_id.rs Outdated Show resolved Hide resolved
orb-info/src/orb_name.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
.github/workflows/rust-ci.yaml Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
TheButlah
TheButlah requested changes Feb 14, 2025
View reviewed changes
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
TheButlah
TheButlah requested changes Feb 14, 2025
View reviewed changes
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
TheButlah
TheButlah approved these changes Feb 14, 2025
View reviewed changes
orb-info/src/orb_token.rs Outdated Show resolved Hide resolved
@TheButlah TheButlah enabled auto-merge (squash) February 14, 2025 19:02
@TheButlah
Copy link
Collaborator

TheButlah commented Feb 14, 2025 •
edited
Loading

Awesome work @paulquinn00! Thanks for the patience during the review process. Approved.

@TheButlah TheButlah merged commit 559c161 into main Feb 14, 2025
14 checks passed
@TheButlah TheButlah deleted the FM-370-orb-info branch February 14, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheButlah TheButlah TheButlah approved these changes

@fouge fouge Awaiting requested review from fouge

@oldgalileo oldgalileo Awaiting requested review from oldgalileo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulquinn00 @TheButlah