Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to open-telemetry/api 1.0.1 #48

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

neiluJ
Copy link
Collaborator

@neiluJ neiluJ commented Dec 18, 2023

This PR is to prevent this error following the 1.0.1 release of api last week:

PHP Fatal error:  Declaration of Instrumentation\Metrics\Meter::createCounter(string $name, ?string $unit = null, ?string $description = null): OpenTelemetry\API\Metrics\CounterInterface must be compatible with OpenTelemetry\API\Metrics\MeterInterface::createCounter(string $name, ?string $unit = null, ?string $description = null, array $advisory = []): OpenTelemetry\API\Metrics\CounterInterface in /var/www/html/vendor/worldia/instrumentation-bundle/src/Metrics/Meter.php on line 26

@cyve
Copy link
Collaborator

cyve commented Dec 19, 2023

Hi @neiluJ, thanks for your first contribution ;-)

We should also bump the composer version of open-telemetry/api and open-telemetry/sdk to ^1.0.1, because the code will no longer be compatible with versions < 1.0.1 (and now that the version 1.0 is released, we can get rid of the @dev version)

@neiluJ
Copy link
Collaborator Author

neiluJ commented Dec 19, 2023

Hi @neiluJ, thanks for your first contribution ;-)

We should also bump the composer version of open-telemetry/api and open-telemetry/sdk to ^1.0.1, because the code will no longer be compatible with versions < 1.0.1 (and now that the version 1.0 is released, we can get rid of the @dev version)

you are totally right, sorry for that

@neiluJ neiluJ force-pushed the feat/update-to-101 branch from 92e627a to f8d59db Compare December 19, 2023 09:50
@cyve cyve merged commit 1b6233a into worldia:master Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants