Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
TracedResponse:: toStream()
, we end the tracing just after the creation of the stream. But when the server do HTTP streaming, the stream is empty at the beginning, and will be filled progressively. Later in theendTracing()
method, we usestream_get_content()
to add the response body to the trace attribute, which means PHP waits for the full body to be downloaded before continue to execute some code.In this PR, we end the tracing when we receive the last chunk of the HTTP response. This allows PHP to continue to execute code asynchronously after the call to
toStream()
, while the response body is downloaded.