Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Common): Sanitize headers before adding them to span attributes #52

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feat(Common): Sanitize headers before adding them to span attributes #52

merged 2 commits into from
Feb 1, 2024

Conversation

neiluJ
Copy link
Collaborator

@neiluJ neiluJ commented Jan 30, 2024

We want to prevent this error from happening:

attribute with non-primitive or non-homogeneous array of primitives dropped: response.headers

@neiluJ neiluJ force-pushed the feat/filter-headers branch from 7925901 to c2ca21b Compare January 30, 2024 09:42
@neiluJ neiluJ force-pushed the feat/filter-headers branch from c2ca21b to b87e5b4 Compare January 30, 2024 09:58
@neiluJ neiluJ requested a review from cyve January 30, 2024 10:05
@neiluJ neiluJ self-assigned this Jan 30, 2024
@cyve cyve merged commit a9444b0 into master Feb 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyve cyve Awaiting requested review from cyve

Assignees

@neiluJ neiluJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neiluJ @cyve