Fix key for array callback for project (#58)

worldia · May 20, 2016 · 9aefd4b · 9aefd4b
1 parent 28e75e7
commit 9aefd4b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/lib/Textmaster/Model/Project.php b/lib/Textmaster/Model/Project.php
@@ -184,11 +184,11 @@ public function getCallback()
      */
     public function setCallback(array $callback)
     {
-        if (!array_key_exists(ProjectInterface::STATUS_IN_PROGRESS, $callback)) {
+        if (!array_key_exists(self::CALLBACK_KEY, $callback) || 1 < count($callback)) {
             throw new InvalidArgumentException(sprintf(
                 'Only key for array callback allowed is "%s"',
-                ProjectInterface::STATUS_IN_PROGRESS
-             ));
+                self::CALLBACK_KEY
+            ));
         }
 
         $this->data['callback'] = $callback;

diff --git a/lib/Textmaster/Model/ProjectInterface.php b/lib/Textmaster/Model/ProjectInterface.php
@@ -28,6 +28,8 @@ interface ProjectInterface
     const STATUS_PAUSED = 'paused';
     const STATUS_CANCELED = 'canceled';
 
+    const CALLBACK_KEY = 'project_in_progress';
+
     /**
      * Get id.
      *

diff --git a/test/Textmaster/Unit/Model/ProjectTest.php b/test/Textmaster/Unit/Model/ProjectTest.php
@@ -80,7 +80,7 @@ public function shouldCreateEmpty()
         $category = 'C014';
         $briefing = 'Lorem ipsum...';
         $options = array('language_level' => 'premium');
-        $callback = array(ProjectInterface::STATUS_IN_PROGRESS => 'http://callback.url');
+        $callback = array(ProjectInterface::CALLBACK_KEY => 'http://callback.url');
 
         $project = new Project($this->clientMock);
         $project