ethereum: Set impl initialised during setup (fixes #1930)

wormhole-foundation · Nov 23, 2022 · 648b361 · 648b361
1 parent 395bb0f
commit 648b361
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/ethereum/contracts/Setup.sol b/ethereum/contracts/Setup.sol
@@ -35,5 +35,9 @@ contract Setup is Setters, ERC1967Upgrade {
         setEvmChainId(evmChainId);
 
         _upgradeTo(implementation);
+
+        // See https://github.com/wormhole-foundation/wormhole/issues/1930 for
+        // why we set this here
+        setInitialized(implementation);
     }
 }
diff --git a/ethereum/contracts/bridge/BridgeSetup.sol b/ethereum/contracts/bridge/BridgeSetup.sol
@@ -36,5 +36,9 @@ contract BridgeSetup is BridgeSetters, ERC1967Upgrade {
         setEvmChainId(evmChainId);
 
         _upgradeTo(implementation);
+
+        // See https://github.com/wormhole-foundation/wormhole/issues/1930 for
+        // why we set this here
+        setInitialized(implementation);
     }
 }
diff --git a/ethereum/contracts/nft/NFTBridgeSetup.sol b/ethereum/contracts/nft/NFTBridgeSetup.sol
@@ -33,5 +33,9 @@ contract NFTBridgeSetup is NFTBridgeSetters, ERC1967Upgrade {
         setEvmChainId(evmChainId);
 
         _upgradeTo(implementation);
+
+        // See https://github.com/wormhole-foundation/wormhole/issues/1930 for
+        // why we set this here
+        setInitialized(implementation);
     }
 }