Node upgrade libp2p #3716
Closed
Node upgrade libp2p #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
changed the base branch from
main
to
node_always_cutover_to_quic-v1
djb15
approved these changes
Jan 16, 2024
|
This makes me think of #3631. Perhaps we can do both of these PRs? I had to unfortunately update almost everything due to that one dep requiring updating all of the open telemetry stuff which is an almost impossible maze of deps. |
SEJeff
approved these changes
Jan 17, 2024
|
Closing this PR in favor of #3631. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the version of
libp2pused by the guardian in preparation for upgrading to go 1.21.Note that the
Prettymethod inpeer.IDhas be removed and the docs say to useStringinstead.