wormchain: disable ignite #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
requested review from
nik-suri,
johnsaigle and
mdulin2
as code owners
evan-gray
force-pushed
the
disable-ignite
branch
from
95f29d3
to
1e7d740
Compare
panoel
approved these changes
Nov 12, 2024
nik-suri
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignite, which is used to generate go and TS code for wormchain / Cosmos, now fails due to a deprecated protobuf dependency. As far as I understand, these files are already committed, but the step was left as the ignite build is non-deterministic, so it was not possible to add enforcement in CI that the committed code matches what would be generate (as with the other pre-compiled sources, such as the node protobuf files).
As soon as the version of Ignite is upgraded, the generation should be moved to a CI check like the others to ensure it matches what is committed.