Node/CCQ: Logging changes in watchers #4173
Merged
+25
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
node/ccq_logging_changes
branch
2 times, most recently
from
1dcad28
to
2024422
Compare
bruce-riley
force-pushed
the
node/ccq_logging_changes
branch
from
2024422
to
a09db1e
Compare
bingyuyap
approved these changes
Nov 27, 2024
evan-gray
approved these changes
Nov 27, 2024
panoel
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing CCQ errors in the log that are not really errors, just the users making bad requests. This PR changes those to infos. Also, for Solana, it adds another case were we will retry to read the block info before failing.