Add SD card support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idigdoug
approved these changes
Jun 20, 2024
|
|
||
| #pragma pack(1) | ||
|
|
||
| typedef struct _MSHC_IDMAC_DESCRIPTOR { |
There was a problem hiding this comment.
FWIW, current "official" Microsoft opinion of typedef struct _STRUCT {...} STRUCT, *PSTRUCT; is "strongly discourage".
- For code that needs to work on C, the recommendation is
typedef struct STRUCT {...} STRUCT;. - For code that only needs to be C++, the recommendation is
struct STRUCT {...};. _STRUCTwas just because the older MSVC compilers acted funny when both identifiers were the same, but this no longer seems to have any real benefit, and it conflicts with the C/C++ rule "only the compiler-provided headers should define stuff starting with double-underscore or underscore-capital".- Most of the time,
PSTRUCThas no advantage overSTRUCT*, and it has several disadvantages (you have to look for two different types, and it discourages use ofconst).
There was a problem hiding this comment.
If you feel strongly about this, I can change it. I'm not a fan of PSTRUCT either, but nearly all existing MSFT driver code is written this way, and so I've been doing it just for consistency sake.
There was a problem hiding this comment.
I don't feel strongly. You do what seems best. Consistency is a good thing too.
mariobalanica
force-pushed
the
dwcmshc-wip
branch
2 times, most recently
from
0ad8df5 to
25b0b46
Compare
This library allows the SD/eMMC drivers to control necessary clocks/voltages in both normal and crashdump environments. Corresponding TF-A patch: worproject/arm-trusted-firmware@b6c0df4 Signed-off-by: Mario Bălănică <[email protected]>
This is an sdport-based miniport driver for the two MSHC instances on RK3588: one for SD card slot, the other for SDIO Wi-Fi. Features: - Speed modes: Default, HS, SDR50, SDR104 - Internal 32-bit scatter/gather DMA support - Card detection - Crashdump support To-do: - Test eMMC support - SDIO (e.g. CMD53) - Support SD version 1 cards (they don't respond to CMD8 by design, which makes sdport assume it's not an SD card at all) Known issues: - Plugging/unplugging the card quickly can lead to a bugcheck. This happens due to race conditions in sdport w.r.t. card removal and request completion. It ends up dereferencing a NULL pointer, which was supposed to be the outstanding request. Signed-off-by: Mario Bălănică <[email protected]>
dwcmshc depends on GPIO for card detection. When booting from SD, the GPIO driver must be loaded first. Signed-off-by: Mario Bălănică <[email protected]>
mariobalanica
force-pushed
the
dwcmshc-wip
branch
from
25b0b46 to
6686689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an sdport-based miniport driver for the two MSHC instances on
RK3588: one for SD card slot, the other for SDIO Wi-Fi.
Features:
To-do:
which makes sdport assume it's not an SD card at all)
Known issues:
happens due to race conditions in sdport w.r.t. card removal and
request completion. It ends up dereferencing a NULL pointer, which was
supposed to be the outstanding request.