Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/official thing models #15

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Feat/official thing models #15

merged 4 commits into from
Nov 22, 2023

Conversation

hadjian
Copy link
Contributor

@hadjian hadjian commented Nov 20, 2023

  • Checking if Author and Manufacturer are equal before calling model.ParseTMID()
  • Should this be a method of the ThingModel model?

alexbrdn
alexbrdn reviewed Nov 20, 2023
View reviewed changes
internal/commands/fetch.go Show resolved Hide resolved
internal/toc/toc.go Show resolved Hide resolved
@hadjian hadjian marked this pull request as ready for review November 22, 2023 12:25
@hadjian hadjian merged commit e95af8d into main Nov 22, 2023
1 check passed
@hadjian hadjian deleted the feat/official-thing-models branch November 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbrdn alexbrdn alexbrdn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadjian @alexbrdn