-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5 #156
base: master
Are you sure you want to change the base?
Conversation
"esbuild cdn_min --watch", | ||
"esbuild main --watch" | ||
] | ||
"assets.build": ["cmd --cd assets node build.js"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the version number (currently 0.15.0-rc4
) it should work properly since I build the files and publish them as a package to hex. So I think this only applies when you're using the github branch. Not sure if this is really an issue. Also I think this might have been an issue in the previous version too, not specific to the Svelte 5 release I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, makes sense. Thanks for the clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember now why I was using this branch, I used my own fork to rebase master branch because this PRs branch doesn't include this commit 97ed136 from master. Which seems to resolve another issue where mix live_svelte.setup
seems to have issues finishing correctly. It looks as if I am missing package.json
.
Should you rebase and release a new RC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this comment in this open issue. So I think to use the RC on a new project we will need the rebase with the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
Just released 0.15.0-rc.5
Mostly by running `npx sv migrate svelte-5`
This is a nice way to test if maps are updating properly
- LiveJson stopped working - Experimental slots stopped working
42a5228
to
466739f
Compare
Small update on this one, so the reason this is not merged yet is that I have a project where it's not working 100%. There's an issue when using components that use child Svelte components in that project. This does not occur in other projects. I haven't had the chance to look at it more deeply, as soon as that's fixed and I don't hear any issues in the community, this will be merged and released |
Thanks for the BUMP @woutdp |
So for parity tests I copied the example_project into the new phoenix app. I ran into a Svelte 5 compatibility issue. Also pointed out in this issue Sure enough, adding
I would have thought that this would not have happened because when I look at the changes on this branch it looks as if you have taken care of this here with the new I then experienced another issue Something seemed off, and when I clicked into the offending code in the browser I could see that I was looking at old code. Turns out I looked back at I think we need to cut another release to resolve the issue with the artifacts. |
@christophertrudel thank you, just released |
Confirmed. Thanks for the quick turn around. |
import TextInput from "./TextInput.svelte" | ||
|
||
export let live | ||
let {live} = $props() | ||
|
||
let textInput = "Content" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be let textInput = $state("Content")
@@ -10,7 +12,7 @@ | |||
} | |||
</script> | |||
|
|||
<form on:submit|preventDefault={handleForm}> | |||
<form onsubmit={preventDefault(handleForm)}> | |||
<TextInput value={textInput} name="element" id="123456" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be <TextInput bind:value={textInput} name="element" id="123456" />
So, at this moment, to work with
to the mix file - and - things should work? |
@cvkmohan that is correct. And follow instructions here https://github.com/woutdp/live_svelte/tree/svelte-5?tab=readme-ov-file#installation |
Closes: