Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp post meta clean-duplicates <id> <key> command #366

Merged
merged 12 commits into from
Aug 31, 2022

Conversation

BhargavBhandari90
Copy link
Contributor

@BhargavBhandari90 BhargavBhandari90 commented Aug 28, 2022

Fixes: #356

Need suggestions/corrections for labelling.

QUESTION: Should we do the same for the user and term meta commands.?

@BhargavBhandari90 BhargavBhandari90 requested a review from a team as a code owner August 28, 2022 06:52
@BhargavBhandari90 BhargavBhandari90 changed the title WIP : Issue #356 - Add wp post meta clean-duplicates <id> <key> command Issue #356 - Add wp post meta clean-duplicates <id> <key> command Aug 29, 2022
@BhargavBhandari90 BhargavBhandari90 changed the title Issue #356 - Add wp post meta clean-duplicates <id> <key> command Add wp post meta clean-duplicates <id> <key> command Aug 29, 2022
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Left a few comments on the test conditions.

Need suggestions/corrections for labelling.

Not sure I follow... can you explain further?

Should we do the same for the user and term meta commands.?

I think we can hold off for now. Should an actual need arise in the future, it should be simple enough to abstract this out.

features/post-meta.feature Outdated Show resolved Hide resolved
features/post-meta.feature Outdated Show resolved Hide resolved
features/post-meta.feature Outdated Show resolved Hide resolved
features/post-meta.feature Outdated Show resolved Hide resolved
features/post-meta.feature Outdated Show resolved Hide resolved
src/Post_Meta_Command.php Show resolved Hide resolved
@BhargavBhandari90
Copy link
Contributor Author

BhargavBhandari90 commented Aug 29, 2022

@danielbachhuber

Need suggestions/corrections for labelling.

Not sure I follow... can you explain further?

I mean command is clean-duplicates and we are displaying a success message like Cleaned up duplicate enclosures.

So the word enclosures is correct? OR should we have something like Cleaned up duplicate metadata.?

@danielbachhuber
Copy link
Member

I mean command is clean-duplicates and we are displaying a success message like Cleaned up duplicate enclosures.

So the word enclosures is correct? OR should we have something like Cleaned up duplicate metadata.?

@BhargavBhandari90 Oh, I see.

The message should be something like Cleaned up duplicate '<meta-key>' meta values.

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, @BhargavBhandari90 ! 🎉

I made a few more changes you might find useful to review ^

Overall, you've did a great job 😊

@BhargavBhandari90
Copy link
Contributor Author

Thank You @danielbachhuber

I made a few more changes you might find useful to review ^

Yep, I saw that.

@danielbachhuber danielbachhuber added this to the 2.2.4 milestone Aug 31, 2022
@danielbachhuber danielbachhuber merged commit 35fe11a into wp-cli:master Aug 31, 2022
@schlessera
Copy link
Member

Great work on this!

A minor thing: This PR messed up the formatting of the JSON files in the Behat tests. I'll get that cleaned up again in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wp post meta clean-duplicates <id> <key> command
4 participants