Fix two Lintian errors in generated Debian package #594
Conversation
| @@ -31,8 +31,8 @@ Architecture: all | |||
| Maintainer: Alain Schlesser <[email protected]> | |||
| Section: php | |||
| Priority: optional | |||
| Depends: php5-cli (>= 5.6) | php-cli | php7-cli, php5-mysql | php5-mysqlnd | php7.0-mysql | php7.1-mysql | php7.2-mysql | php7.3-mysql | php7.4-mysql | php8.0-mysql | php8.1-mysql | php8.2-mysql | php-mysql, mysql-client | mariadb-client | |||
There was a problem hiding this comment.
What's the significance of dropping all of these dependencies?
There was a problem hiding this comment.
- Fix Lintian errors
- Drop support for PHP 5.6 (EOL Dec 31, 2018)
- Keep support for legacy PHP 7 thanks to Provides fields
- Simplify dependencies to make it easier to maintain
Please note that I have revised one dependency (php-mysqlnd -> php-mysql | php-mysqlnd)
There was a problem hiding this comment.
Hmm not sure about dropping PHP 5.6 support for this package, as WP-CLI in fact still supports PHP 5.6. Could we restore that part somehow?
There was a problem hiding this comment.
@swissspidy, Yes ... commit 54056c0 restores PHP 5.6 support.
Downside is that Lintian reports the php-script-but-no-php-cli-dep error again.
WordPress 6.3 “Lionel” discontinued support for PHP 5 (Aug 8, 2023).
Are there any plans for WP-CLI to do the same?
If it is not imminent, I can create a lintian-override file.
There was a problem hiding this comment.
Are there any plans for WP-CLI to do the same?
Not until Aug 8, 2024. See https://make.wordpress.org/cli/2019/01/15/wp-cli-php-requirements-strategy/
lewart3
force-pushed
the
main
branch
2 times, most recently
from
a990f5c
to
1751452
Compare
|
Thank you, @swissspidy ! |
|
Not sure we want to actually have a hardcoded date in there... I imagine next August we'll release a new version of WP-CLI that officially drops support. Then we can remove the support here. |
|
It is nice to have zero lintian warnings. So modifying dependencies is not a good idea. |
For some numbers, here is a table based on the Debian Popularity Contest: |
|
@lewart3 WP-CLI should be packaged as if it was the time of Debian jessie but be compatible with current stable. |
|
@szepeviktor, I completely agree. |
I do not know that. |
This Pull request says: Does that suffice? |
|
I do not know what to add here as an answer. |
|
@szepeviktor I'd love to better understand your dependencies objection. Here's what I'm hearing so far:
Am I understanding this correctly? |
YESS!! |
Co-authored-by: Alain Schlesser <[email protected]>
|
@schlessera , allow me to address your second point:
This is what you are hearing, but it is not true. |
|
@lewart3 This is not about staying compatible with PHP 5.6, but rather about the package staying compatible with the earliest version of Debian that supports PHP 5.6 and with its entire package ecosystem. |
|
@schlessera , I installed it, with some difficulty, on Debian 8.11 (jessie). $ cat go $ ./go + sudo dpkg --force-depends -i php-wpcli_2.9.1_all.deb Setting up php-wpcli (2.9.0) ... + sudo apt-get --fix-broken -y install Creating config file /etc/php5/mods-available/pdo.ini with new version Creating config file /etc/php5/mods-available/opcache.ini with new version Creating config file /etc/php5/cli/php.ini with new version Creating config file /etc/php5/mods-available/mysql.ini with new version Creating config file /etc/php5/mods-available/mysqli.ini with new version Creating config file /etc/php5/mods-available/pdo_mysql.ini with new version Creating config file /etc/php5/mods-available/readline.ini with new version + wp cli version + wp cli info |
Fixes #593 Lintian reports php-wpcli_2.9.0_all.deb has two errors
Thank you!
Daniel Lewart
Urbana, Illinois