Fix: Correct number formatting by removing unnecessary price separators #888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
This pull request addresses an issue with number formatting in the maxPrice and minPrice filters for product queries in WPGraphQL WooCommerce. Previously, when users entered values greater than 999, the query failed to return the correct products due to improper formatting.
Specifically, when values over 999 were used in the
maxPrice
orminPrice
filters, the query did not return the expected products, as demonstrated in the screenshots below.The new commit resolves this issue by removing all number separators
,
and.
The previous implementation used str_replace to remove periods.
but it did not account for commas,
which are also used as separators in large numbers. This has now been corrected.Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
Before:


After:
Any other comments?
...
Where has this been tested?
WooGraphQL Version: 0.21.0
WPGraphQL Version: 1.28.0
WordPress Version: 6.6.1
WooCommerce Version: 7.8.1