-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a plugin family package to be shared across our plugins #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README is still WIP. |
Done ✅ |
remyperona
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we update the repository name from wp-media-plugin-family
to plugin-family
? The namespace is already there.
We should also add PHPStan to the CI
remyperona
requested changes
Oct 17, 2024
tests/Unit/src/Model/PluginFamily/filterPluginsByActivation.php
Outdated
Show resolved
Hide resolved
tests/Unit/src/Model/PluginFamily/filterPluginsByActivation.php
Outdated
Show resolved
Hide resolved
remyperona
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A package to organise and display WP Media plugin family across other members.
Fixes wp-media/imagify-plugin#908
Explain how this code impacts users.
Displays the WP Media plugin family across other member plugins.
Type of change
Detailed scenario
No Issue
Technical description
Documentation
A composer package that gathers all the member plugins data and sorts them based on activated status ordered by
categorized
oruncategorized
and then adds a controller handler to perform installation & activation actions.New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style
Additional Checks