Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a plugin family package to be shared across our plugins #1

Merged
merged 32 commits into from
Oct 21, 2024

Conversation

jeawhanlee
Copy link
Collaborator

Description

A package to organise and display WP Media plugin family across other members.

Fixes wp-media/imagify-plugin#908

Explain how this code impacts users.
Displays the WP Media plugin family across other member plugins.

Type of change

  • Release

Detailed scenario

No Issue

Technical description

Documentation

A composer package that gathers all the member plugins data and sorts them based on activated status ordered by categorized or uncategorized and then adds a controller handler to perform installation & activation actions.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@jeawhanlee jeawhanlee self-assigned this Oct 15, 2024
@jeawhanlee jeawhanlee marked this pull request as ready for review October 15, 2024 18:55
@jeawhanlee jeawhanlee requested a review from a team October 15, 2024 18:58
@jeawhanlee
Copy link
Collaborator Author

The README is still WIP.

@jeawhanlee
Copy link
Collaborator Author

The README is still WIP.

Done ✅

Copy link

@remyperona remyperona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the repository name from wp-media-plugin-family to plugin-family? The namespace is already there.

We should also add PHPStan to the CI

src/Model/PluginFamily.php Outdated Show resolved Hide resolved
src/Model/PluginFamily.php Outdated Show resolved Hide resolved
src/Controller/PluginFamilyInterface.php Outdated Show resolved Hide resolved
src/Controller/PluginFamilyInterface.php Outdated Show resolved Hide resolved
src/Controller/PluginFamily.php Outdated Show resolved Hide resolved
src/Controller/PluginFamily.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@jeawhanlee jeawhanlee requested a review from remyperona October 17, 2024 12:03
src/Model/PluginFamily.php Show resolved Hide resolved
phpstan.neon.dist Show resolved Hide resolved
@jeawhanlee jeawhanlee requested a review from remyperona October 18, 2024 10:37
@jeawhanlee jeawhanlee added this pull request to the merge queue Oct 21, 2024
Merged via the queue into trunk with commit aa7206c Oct 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make plugins family module shareable across our products.
2 participants