Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/exclude youtube thumbnail from lazyload #116

Merged

Conversation

jeawhanlee
Copy link
Contributor

Description

This PR excludes youtube thumbnail from lazyload

Fixes issue: wp-media/wp-rocket#6312

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@jeawhanlee jeawhanlee added the enhancement New feature or request label Jan 18, 2024
@jeawhanlee jeawhanlee self-assigned this Jan 18, 2024
@jeawhanlee jeawhanlee requested a review from a team January 18, 2024 11:19
@jeawhanlee jeawhanlee merged commit efbc71e into develop Feb 26, 2024
7 checks passed
@jeawhanlee jeawhanlee deleted the enhancement/exclude-youtube-thumbnail-from-lazyload branch February 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants