Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter empty values before using the array #117

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Jul 16, 2024

Description

Documentation

User documentation

Prevent PHP warning when using strpos() with empty value

Technical documentation

Use array_filter() to remove empty values from the excluded values array

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona self-assigned this Jul 16, 2024
@remyperona remyperona requested a review from a team July 16, 2024 14:34
@remyperona remyperona added the bug Something isn't working label Jul 16, 2024
@remyperona remyperona marked this pull request as ready for review July 16, 2024 14:37
@remyperona remyperona merged commit 326ed00 into develop Jul 16, 2024
7 checks passed
@remyperona remyperona deleted the fix/filter-empty-values branch July 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants