Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typed filter #120

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Use typed filter #120

merged 2 commits into from
Jul 30, 2024

Conversation

remyperona
Copy link
Contributor

Description

Documentation

User documentation

Prevent error in case of filter returning a value which is not a boolean

Technical documentation

Use wp-media/apply-filters-typed library to handle the strict typing

Type of change

  • Bug fix (non-breaking change which fixes an issue).

New dependencies

wp-media/apply-filters-typed library

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.

@remyperona remyperona added the bug Something isn't working label Jul 30, 2024
@remyperona remyperona requested a review from a team July 30, 2024 12:59
@remyperona remyperona self-assigned this Jul 30, 2024
Copy link

@nicomollet nicomollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@remyperona remyperona merged commit cfaa206 into develop Jul 30, 2024
9 checks passed
@remyperona remyperona deleted the enhancement/add-apply-filters-typed branch July 30, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants