Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 7326: 3.19-prealpha: Same preloaded font URL is added twice to DB preload fonts table #44

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Feb 24, 2025

Description

Fixes wp-media/wp-rocket#7326
Fixes issues with same font urls added multiple times in DB

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

What was tested

Tested that the beacon did not send duplicate urls to DB.
Tested both Manually and Automated.

How to test

  • Visit a template setup like this one
  • Check DB and see that only one entry is there.
    Screenshot 2025-02-25 at 00 12 58

Technical description

Documentation

Used Set to create unique entries.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

@jeawhanlee jeawhanlee self-assigned this Feb 24, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e20092d1 50.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e20092d) Report Missing Report Missing Report Missing
Head commit (c88e91c) 1377 1054 76.54%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#44) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeawhanlee jeawhanlee merged commit 8206c88 into feature/3.19-beacons Feb 24, 2025
5 of 6 checks passed
@jeawhanlee jeawhanlee deleted the fix/7326-3.19-prealpha-same-preloaded-font-url-added-twice-to-db branch February 24, 2025 23:29
@jeawhanlee jeawhanlee mentioned this pull request Feb 24, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant