Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3: Ignore random errors in certain cases #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeawhanlee
Copy link
Collaborator

@jeawhanlee jeawhanlee commented Jan 10, 2025

Description

Fixes #3
Introduces exclusions of known WP Rocket related errors in debug.log

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Errors Identified here will be flagged in e2e with develop branch

Technical description

Documentation

Added an exclusion for known wpr related errors, gather all wpr related errors and filter based on matches, also new patterns can be added using filters.

Patterns used:

'wp-rocket/inc/Dependencies/Database',
'WP_Rocket(.*)Table->create',
'wp-rocket/inc/Engine/Common/Database/Queries/AbstractQuery',
'Failed opening(.*?)wp-rocket/',

New dependencies

N/A

Risks

New type of errors with patterns not already covered could surface, that's the reason the option for a filter is available to still work till new pattern is implemented.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

  • No test suite setup for this repo
  • No entry points to protect
  • No user error to handle

@jeawhanlee jeawhanlee self-assigned this Jan 10, 2025
@jeawhanlee jeawhanlee requested a review from a team January 10, 2025 12:31
@jeawhanlee jeawhanlee added the enhancement New feature or request label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore random errors in certain cases
2 participants