Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
adjust is_relative conditions
Browse files Browse the repository at this point in the history
wordpressfan committed Apr 25, 2024
1 parent 3fef09c commit 01c2664
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions inc/Engine/Media/AboveTheFold/Frontend/Controller.php
Original file line number Diff line number Diff line change
@@ -8,9 +8,11 @@
use WP_Rocket\Engine\Media\AboveTheFold\Database\Queries\AboveTheFold as ATFQuery;
use WP_Rocket\Engine\Media\AboveTheFold\Context\Context;
use WP_Rocket\Engine\Optimization\RegexTrait;
use WP_Rocket\Engine\Optimization\UrlTrait;

class Controller {
use RegexTrait;
use UrlTrait;

/**
* Options instance
@@ -250,24 +252,24 @@ private function generate_lcp_link_tag_with_sources( $lcp ): array {
switch ( $lcp->type ) {
case 'img':
$sources[] = $lcp->src;
$tag .= $start_tag . 'href="' . esc_url( $lcp->src ) . '"' . $end_tag;
$tag .= $start_tag . 'href="' . ( $this->is_relative( $lcp->src ) ? esc_attr( $lcp->src ) : esc_url( $lcp->src ) ) . '"' . $end_tag;
break;
case 'img-srcset':
$sources[] = $lcp->src;
$tag .= $start_tag . 'href="' . esc_url( $lcp->src ) . '" imagesrcset="' . $lcp->srcset . '" imagesizes="' . $lcp->sizes . '"' . $end_tag;
$tag .= $start_tag . 'href="' . ( $this->is_relative( $lcp->src ) ? esc_attr( $lcp->src ) : esc_url( $lcp->src ) ) . '" imagesrcset="' . esc_attr( $lcp->srcset ) . '" imagesizes="' . esc_attr( $lcp->sizes ) . '"' . $end_tag;
break;
case 'bg-img-set':
foreach ( $lcp->bg_set as $set ) {
$sources[] = $set->src;
}

$tag .= $start_tag . 'imagesrcset="' . implode( ',', $sources ) . '"' . $end_tag;
$tag .= $start_tag . 'imagesrcset="' . esc_attr( implode( ',', $sources ) ) . '"' . $end_tag;
break;
case 'bg-img':
foreach ( $lcp->bg_set as $set ) {
$sources[] = $set->src;

$tag .= $start_tag . 'href="' . $set->src . '"' . $end_tag;
$tag .= $start_tag . 'href="' . $this->is_relative( $set->src ) ? esc_attr( $set->src ) : esc_url( $set->src ) . '"' . $end_tag;
}
break;
case 'picture':
2 changes: 1 addition & 1 deletion inc/Engine/Optimization/UrlTrait.php
Original file line number Diff line number Diff line change
@@ -135,6 +135,6 @@ protected function get_file_content( $file ) {
* @return bool
*/
protected function is_relative( string $url ): bool {
return ! empty( preg_match( '/^\./', $url ) );
return ! empty( preg_match( '/^\./', $url ) ) || empty( wp_parse_url( $url, PHP_URL_HOST ) );
}
}

0 comments on commit 01c2664

Please sign in to comment.